lukasandClaude Opus 4.8
4e077f1a37
Backend foundation for the plugin platform (SPEC §11), Phases 1-3.
Phase 1 — SDK + loader:
- app/plugins/types.py: frozen Plugin/UiManifest/Slot/Page/JobSpec contract.
- app/plugins/sdk.py: sdk(name) facade — the only app.* import allowed for plugins
(scoped session, plugin.{name}.* publish, blob, outbox, settings, SSRF http_get, KV, enqueue).
- app/plugins/loader.py: entry-point discovery (webmail.plugins), hook forwarding
(API + worker), router mounting at /api/plugins/{name}, ui-manifest aggregation.
- plugin_kv core table (migration 0013) + GET /api/plugins/ui-manifest.
Phase 2 — non-removable core plugins + DB-enforced privacy:
- builtin flag (calendar/contacts will be builtin=True; uninstall refuses them).
- RLS per-user isolation on plg_* tables: least-privilege webmail_plugin role
(migration 0014), plugin_session(user_id) sets LOCAL ROLE + app.current_user_id,
rls.enable_rls() (ENABLE+FORCE RLS + USING/WITH CHECK policy). Mail untouched.
- Per-plugin Alembic runner (shared env, dedicated version table) + install/uninstall
--drop-data CLI; skeleton fixture proves install -> run -> uninstall --drop-data
leaves zero residue (§12 M3 acceptance).
Phase 3 — plugin jobs (§11.2):
- JobSpec registered as arq function plg.{plugin}.{func} + cron (5-field parser);
singleton=True guarded by a per-(plugin,user) Redis lock; wired onto the shared
interactive worker.
Gates: ruff, mypy --strict (94 files + tests), full suite 326 passed. RLS isolation,
migration round-trip, and singleton lock covered by tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rcj3TpydMTzTSmU7kunzf8
39 lines
1.2 KiB
Python
39 lines
1.2 KiB
Python
"""Builtin (non-removable core) plugin handling (SPEC §11 / §12)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from app.plugins import loader
|
|
from app.plugins.sdk import Plugin
|
|
|
|
|
|
def test_builtin_defaults_false() -> None:
|
|
assert Plugin(name="filters", version="1").builtin is False
|
|
assert Plugin(name="calendar", version="1", builtin=True).builtin is True
|
|
|
|
|
|
def test_assert_removable_blocks_builtin() -> None:
|
|
loader.set_plugins_for_test(
|
|
[
|
|
Plugin(name="filters", version="1"), # removable
|
|
Plugin(name="calendar", version="1", builtin=True), # core, non-removable
|
|
]
|
|
)
|
|
assert loader.assert_removable("filters").name == "filters"
|
|
|
|
with pytest.raises(loader.PluginRemovalError, match="builtin"):
|
|
loader.assert_removable("calendar")
|
|
with pytest.raises(loader.PluginRemovalError, match="unknown"):
|
|
loader.assert_removable("nope")
|
|
|
|
|
|
def test_builtin_surfaces_in_ui_manifest() -> None:
|
|
from app.plugins.sdk import UiManifest
|
|
|
|
loader.set_plugins_for_test(
|
|
[Plugin(name="calendar", version="1", builtin=True, ui_manifest=UiManifest())]
|
|
)
|
|
entry = loader.build_ui_manifest()["plugins"][0]
|
|
assert entry["name"] == "calendar" and entry["builtin"] is True
|