lukasandClaude Opus 5.5
addb2232a1
Security (ultimo-security-report.md):
- Security headers on every response, the app shell included: they lived at
server level and nginx dropped them in any location with its own header.
CSP, framing, nosniff, referrer, permissions (docker/nginx-security.conf).
- Plain HTTP forwarded by the reverse proxy is redirected to HTTPS; HSTS on
HTTPS responses. server_tokens off.
- Cross-site state-changing /api requests refused (login CSRF), WebSocket too.
- Validation errors in the usual error shape, without the request model.
- New-password policy: max 128, common/own-address/repeated refused,
breached-password check (HIBP k-anonymity, fails open).
- Message HTML: links keep only http(s)/mailto (sanitizer v6); the HTML
endpoint carries its own no-script CSP.
- Outbound fetches pinned to the checked IP (DNS rebinding); external
IMAP/SMTP servers re-checked before each connection; CGNAT and mapped
addresses counted as non-public.
Fixes from testing:
- IDLE loop catches up before idling: mail that came while the worker was
away no longer waits up to 10 minutes.
- Restore from Spam/Trash/Archive moves only the removed messages, not your
reply in Sent.
- Narrow desktop list stacks sender/subject/snippet (subject was squeezed
to nothing at the default width), with hover actions.
- Phone: wide emails scale to fit the screen.
- Singular forms ("1 message"); no zip button for a single attachment;
app passwords no longer claim "never used" for mail apps.
- ruff format across the backend.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
61 lines
1.8 KiB
Python
61 lines
1.8 KiB
Python
"""FastAPI application factory (SPEC §2 ``app/main.py``)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import AsyncIterator
|
|
from contextlib import asynccontextmanager
|
|
|
|
from fastapi import FastAPI
|
|
from sqlalchemy import text
|
|
|
|
from app.config import get_settings
|
|
from app.db import dispose_engine, get_engine
|
|
from app.redis_client import close_redis, get_redis
|
|
|
|
|
|
@asynccontextmanager
|
|
async def lifespan(app: FastAPI) -> AsyncIterator[None]:
|
|
"""Warm shared resources on startup, dispose them on shutdown."""
|
|
# Touch settings early so misconfiguration fails fast.
|
|
get_settings()
|
|
# Subscribe plugin hooks so events published in the API process reach them
|
|
# (worker-published events are handled by the worker's own registration).
|
|
from app.events import get_event_bus
|
|
from app.plugins import loader
|
|
|
|
loader.register_hooks(get_event_bus())
|
|
yield
|
|
await close_redis()
|
|
await dispose_engine()
|
|
|
|
|
|
def create_app() -> FastAPI:
|
|
"""Construct the FastAPI application."""
|
|
app = FastAPI(title="Webmail", version="0.1.0", lifespan=lifespan)
|
|
|
|
from app.api.errors import register_error_handlers
|
|
|
|
register_error_handlers(app)
|
|
|
|
from app.security.cross_site import CrossSiteGuard
|
|
|
|
app.add_middleware(CrossSiteGuard)
|
|
|
|
@app.get("/api/healthz")
|
|
async def healthz() -> dict[str, str]:
|
|
"""Liveness/readiness probe: checks DB and Redis (dev-setup §6)."""
|
|
async with get_engine().connect() as conn:
|
|
await conn.execute(text("SELECT 1"))
|
|
await get_redis().ping()
|
|
return {"status": "ok"}
|
|
|
|
@app.get("/api/version")
|
|
async def version() -> dict[str, str]:
|
|
"""Report the running release, for deploy/rollback verification."""
|
|
return {"version": get_settings().app_version}
|
|
|
|
from app.api import register_routers
|
|
|
|
register_routers(app)
|
|
return app
|