lukasandClaude Opus 4.8
4e077f1a37
Backend foundation for the plugin platform (SPEC §11), Phases 1-3.
Phase 1 — SDK + loader:
- app/plugins/types.py: frozen Plugin/UiManifest/Slot/Page/JobSpec contract.
- app/plugins/sdk.py: sdk(name) facade — the only app.* import allowed for plugins
(scoped session, plugin.{name}.* publish, blob, outbox, settings, SSRF http_get, KV, enqueue).
- app/plugins/loader.py: entry-point discovery (webmail.plugins), hook forwarding
(API + worker), router mounting at /api/plugins/{name}, ui-manifest aggregation.
- plugin_kv core table (migration 0013) + GET /api/plugins/ui-manifest.
Phase 2 — non-removable core plugins + DB-enforced privacy:
- builtin flag (calendar/contacts will be builtin=True; uninstall refuses them).
- RLS per-user isolation on plg_* tables: least-privilege webmail_plugin role
(migration 0014), plugin_session(user_id) sets LOCAL ROLE + app.current_user_id,
rls.enable_rls() (ENABLE+FORCE RLS + USING/WITH CHECK policy). Mail untouched.
- Per-plugin Alembic runner (shared env, dedicated version table) + install/uninstall
--drop-data CLI; skeleton fixture proves install -> run -> uninstall --drop-data
leaves zero residue (§12 M3 acceptance).
Phase 3 — plugin jobs (§11.2):
- JobSpec registered as arq function plg.{plugin}.{func} + cron (5-field parser);
singleton=True guarded by a per-(plugin,user) Redis lock; wired onto the shared
interactive worker.
Gates: ruff, mypy --strict (94 files + tests), full suite 326 passed. RLS isolation,
migration round-trip, and singleton lock covered by tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rcj3TpydMTzTSmU7kunzf8
53 lines
1.9 KiB
Python
53 lines
1.9 KiB
Python
"""Namespaced plugin KV store round-trips (SPEC §11 plugin_kv)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
|
|
from sqlalchemy import delete
|
|
from sqlalchemy.ext.asyncio import async_sessionmaker, create_async_engine
|
|
from sqlalchemy.pool import NullPool
|
|
|
|
from app.config import get_settings
|
|
from app.db import session_scope
|
|
from app.identity.passwords import hash_password
|
|
from app.models import User
|
|
from app.plugins.sdk import sdk
|
|
|
|
|
|
async def test_plugin_kv_crud_is_namespaced() -> None:
|
|
engine = create_async_engine(get_settings().database_url, poolclass=NullPool)
|
|
sm = async_sessionmaker(engine, expire_on_commit=False)
|
|
session = sm()
|
|
user = User(handle=f"kv{uuid.uuid4().hex[:8]}@test.local", password_hash=hash_password("pw"))
|
|
session.add(user)
|
|
await session.commit()
|
|
|
|
try:
|
|
kv = sdk("filters").kv(user.id)
|
|
other = sdk("labels").kv(user.id) # different plugin, same user
|
|
|
|
assert await kv.get("rules", default=[]) == [] # missing key -> default
|
|
await kv.set("rules", [{"match": "boss", "flag": "important"}])
|
|
await kv.set("count", 3)
|
|
assert await kv.get("rules") == [{"match": "boss", "flag": "important"}]
|
|
assert await kv.get("count") == 3
|
|
|
|
# Namespacing: the labels plugin sees nothing filters wrote.
|
|
assert await other.get("rules") is None
|
|
assert await other.items() == {}
|
|
|
|
assert await kv.items() == {"rules": [{"match": "boss", "flag": "important"}], "count": 3}
|
|
|
|
await kv.set("count", 4) # upsert overwrites
|
|
assert await kv.get("count") == 4
|
|
|
|
await kv.delete("count")
|
|
assert await kv.get("count") is None
|
|
assert set((await kv.items()).keys()) == {"rules"}
|
|
finally:
|
|
async with session_scope() as cleanup: # cascade drops plugin_kv rows
|
|
await cleanup.execute(delete(User).where(User.id == user.id))
|
|
await session.close()
|
|
await engine.dispose()
|