Security (ultimo-security-report.md):
- Security headers on every response, the app shell included: they lived at
server level and nginx dropped them in any location with its own header.
CSP, framing, nosniff, referrer, permissions (docker/nginx-security.conf).
- Plain HTTP forwarded by the reverse proxy is redirected to HTTPS; HSTS on
HTTPS responses. server_tokens off.
- Cross-site state-changing /api requests refused (login CSRF), WebSocket too.
- Validation errors in the usual error shape, without the request model.
- New-password policy: max 128, common/own-address/repeated refused,
breached-password check (HIBP k-anonymity, fails open).
- Message HTML: links keep only http(s)/mailto (sanitizer v6); the HTML
endpoint carries its own no-script CSP.
- Outbound fetches pinned to the checked IP (DNS rebinding); external
IMAP/SMTP servers re-checked before each connection; CGNAT and mapped
addresses counted as non-public.
Fixes from testing:
- IDLE loop catches up before idling: mail that came while the worker was
away no longer waits up to 10 minutes.
- Restore from Spam/Trash/Archive moves only the removed messages, not your
reply in Sent.
- Narrow desktop list stacks sender/subject/snippet (subject was squeezed
to nothing at the default width), with hover actions.
- Phone: wide emails scale to fit the screen.
- Singular forms ("1 message"); no zip button for a single attachment;
app passwords no longer claim "never used" for mail apps.
- ruff format across the backend.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
78 lines
2.8 KiB
Python
78 lines
2.8 KiB
Python
"""Meilisearch backend (SPEC §8, M2). Runs against the live Meili in the dev/CI
|
|
stack; skips if it is unreachable so the rest of the suite still runs locally."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import time
|
|
import uuid
|
|
|
|
import pytest
|
|
|
|
from app.search.base import SearchDoc
|
|
from app.search.meili import MeiliSearchBackend
|
|
from app.search.queryparser import to_search_query
|
|
|
|
|
|
def _doc(user_id: uuid.UUID) -> SearchDoc:
|
|
return SearchDoc(
|
|
message_id=uuid.uuid4(),
|
|
thread_id=uuid.uuid4(),
|
|
user_id=user_id,
|
|
account_id=uuid.uuid4(),
|
|
mailbox_special_use="inbox",
|
|
from_=[{"name": "Bob Vendor", "email": "bob@vendor.com"}],
|
|
to=[{"name": "Me", "email": "me@x.com"}],
|
|
cc=[],
|
|
subject="Your invoice for March",
|
|
body_text="Please find attached the invoice, amount due soon.",
|
|
attachment_names=["invoice.pdf"],
|
|
has_attachments=True,
|
|
is_unread=True,
|
|
is_starred=False,
|
|
date=int(time.time()),
|
|
size_bytes=2048,
|
|
)
|
|
|
|
|
|
async def _poll(backend: MeiliSearchBackend, q: str, user_id: uuid.UUID) -> int:
|
|
"""Indexing is async in Meili; retry briefly until the doc is searchable."""
|
|
for _ in range(60):
|
|
hits, _c = await backend.query(to_search_query(q, user_id), limit=10, cursor=None)
|
|
if hits:
|
|
return len(hits)
|
|
await asyncio.sleep(0.05)
|
|
return 0
|
|
|
|
|
|
async def test_meili_typo_tolerance_and_filters() -> None:
|
|
backend = MeiliSearchBackend()
|
|
user_id = uuid.uuid4()
|
|
try:
|
|
await backend.index(_doc(user_id))
|
|
|
|
# Acceptance (§12 M2): a typo still finds the message.
|
|
hits, _c = await backend.query(to_search_query("invocie", user_id), limit=10, cursor=None)
|
|
if not hits: # wait for the async index task
|
|
assert await _poll(backend, "invocie", user_id) == 1
|
|
hits, _c = await backend.query(
|
|
to_search_query("invocie", user_id), limit=10, cursor=None
|
|
)
|
|
assert len(hits) == 1
|
|
assert "<mark>" in hits[0].highlights.get("subject", "")
|
|
|
|
async def n(query: str) -> int:
|
|
res, _c = await backend.query(to_search_query(query, user_id), limit=10, cursor=None)
|
|
return len(res)
|
|
|
|
assert await n("is:unread invoice") == 1
|
|
assert await n("is:read invoice") == 0 # the doc is unread
|
|
assert await n("from:vendor") == 1 # field operator folded into the query
|
|
assert await n("larger:1k invoice") == 1
|
|
assert await n("larger:5k invoice") == 0
|
|
assert await n("in:sent invoice") == 0 # doc is in the inbox
|
|
except (ConnectionError, OSError) as exc: # Meili not running locally
|
|
pytest.skip(f"Meilisearch unavailable: {exc}")
|
|
finally:
|
|
await backend.delete_user(user_id)
|