lukasandClaude Opus 4.8
4e077f1a37
Backend foundation for the plugin platform (SPEC §11), Phases 1-3.
Phase 1 — SDK + loader:
- app/plugins/types.py: frozen Plugin/UiManifest/Slot/Page/JobSpec contract.
- app/plugins/sdk.py: sdk(name) facade — the only app.* import allowed for plugins
(scoped session, plugin.{name}.* publish, blob, outbox, settings, SSRF http_get, KV, enqueue).
- app/plugins/loader.py: entry-point discovery (webmail.plugins), hook forwarding
(API + worker), router mounting at /api/plugins/{name}, ui-manifest aggregation.
- plugin_kv core table (migration 0013) + GET /api/plugins/ui-manifest.
Phase 2 — non-removable core plugins + DB-enforced privacy:
- builtin flag (calendar/contacts will be builtin=True; uninstall refuses them).
- RLS per-user isolation on plg_* tables: least-privilege webmail_plugin role
(migration 0014), plugin_session(user_id) sets LOCAL ROLE + app.current_user_id,
rls.enable_rls() (ENABLE+FORCE RLS + USING/WITH CHECK policy). Mail untouched.
- Per-plugin Alembic runner (shared env, dedicated version table) + install/uninstall
--drop-data CLI; skeleton fixture proves install -> run -> uninstall --drop-data
leaves zero residue (§12 M3 acceptance).
Phase 3 — plugin jobs (§11.2):
- JobSpec registered as arq function plg.{plugin}.{func} + cron (5-field parser);
singleton=True guarded by a per-(plugin,user) Redis lock; wired onto the shared
interactive worker.
Gates: ruff, mypy --strict (94 files + tests), full suite 326 passed. RLS isolation,
migration round-trip, and singleton lock covered by tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rcj3TpydMTzTSmU7kunzf8
52 lines
1.5 KiB
Python
52 lines
1.5 KiB
Python
"""FastAPI application factory (SPEC §2 ``app/main.py``)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import AsyncIterator
|
|
from contextlib import asynccontextmanager
|
|
|
|
from fastapi import FastAPI
|
|
from sqlalchemy import text
|
|
|
|
from app.config import get_settings
|
|
from app.db import dispose_engine, get_engine
|
|
from app.redis_client import close_redis, get_redis
|
|
|
|
|
|
@asynccontextmanager
|
|
async def lifespan(app: FastAPI) -> AsyncIterator[None]:
|
|
"""Warm shared resources on startup, dispose them on shutdown."""
|
|
# Touch settings early so misconfiguration fails fast.
|
|
get_settings()
|
|
# Subscribe plugin hooks so events published in the API process reach them
|
|
# (worker-published events are handled by the worker's own registration).
|
|
from app.events import get_event_bus
|
|
from app.plugins import loader
|
|
|
|
loader.register_hooks(get_event_bus())
|
|
yield
|
|
await close_redis()
|
|
await dispose_engine()
|
|
|
|
|
|
def create_app() -> FastAPI:
|
|
"""Construct the FastAPI application."""
|
|
app = FastAPI(title="Webmail", version="0.1.0", lifespan=lifespan)
|
|
|
|
from app.api.errors import register_error_handlers
|
|
|
|
register_error_handlers(app)
|
|
|
|
@app.get("/api/healthz")
|
|
async def healthz() -> dict[str, str]:
|
|
"""Liveness/readiness probe: checks DB and Redis (dev-setup §6)."""
|
|
async with get_engine().connect() as conn:
|
|
await conn.execute(text("SELECT 1"))
|
|
await get_redis().ping()
|
|
return {"status": "ok"}
|
|
|
|
from app.api import register_routers
|
|
|
|
register_routers(app)
|
|
return app
|