lukasandClaude Opus 5.5
addb2232a1
Security (ultimo-security-report.md):
- Security headers on every response, the app shell included: they lived at
server level and nginx dropped them in any location with its own header.
CSP, framing, nosniff, referrer, permissions (docker/nginx-security.conf).
- Plain HTTP forwarded by the reverse proxy is redirected to HTTPS; HSTS on
HTTPS responses. server_tokens off.
- Cross-site state-changing /api requests refused (login CSRF), WebSocket too.
- Validation errors in the usual error shape, without the request model.
- New-password policy: max 128, common/own-address/repeated refused,
breached-password check (HIBP k-anonymity, fails open).
- Message HTML: links keep only http(s)/mailto (sanitizer v6); the HTML
endpoint carries its own no-script CSP.
- Outbound fetches pinned to the checked IP (DNS rebinding); external
IMAP/SMTP servers re-checked before each connection; CGNAT and mapped
addresses counted as non-public.
Fixes from testing:
- IDLE loop catches up before idling: mail that came while the worker was
away no longer waits up to 10 minutes.
- Restore from Spam/Trash/Archive moves only the removed messages, not your
reply in Sent.
- Narrow desktop list stacks sender/subject/snippet (subject was squeezed
to nothing at the default width), with hover actions.
- Phone: wide emails scale to fit the screen.
- Singular forms ("1 message"); no zip button for a single attachment;
app passwords no longer claim "never used" for mail apps.
- ruff format across the backend.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
39 lines
1.5 KiB
Python
39 lines
1.5 KiB
Python
"""Build a MailProvider from an account row (SPEC §10.2 decryption boundary).
|
|
|
|
This module runs only inside the worker/sync context; ``decrypt_secret`` (the
|
|
credential vault) is invoked here to obtain the plaintext mailbox password. It
|
|
must never be imported by API request code.
|
|
|
|
A native account (the user's hosted mailbox, App. D §D.4) has no stored
|
|
password: the worker signs in as itself, acting for the user.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from app.models import Account
|
|
from app.providers.imap_smtp import ImapSmtpProvider, ProviderConfig
|
|
from app.security.crypto import decrypt_secret
|
|
|
|
|
|
def build_provider(account: Account) -> ImapSmtpProvider:
|
|
"""Construct an :class:`ImapSmtpProvider` for ``account`` (password auth, M0)."""
|
|
if account.kind == "native":
|
|
from app.hosted.native import native_provider_config
|
|
|
|
return ImapSmtpProvider(native_provider_config(account.email))
|
|
imap = account.imap_config
|
|
smtp = account.smtp_config
|
|
password = decrypt_secret(account.secret_ct).decode("utf-8")
|
|
config = ProviderConfig(
|
|
imap_host=str(imap["host"]),
|
|
imap_port=int(str(imap["port"])),
|
|
imap_tls=str(imap.get("tls", "ssl")),
|
|
smtp_host=str(smtp["host"]),
|
|
smtp_port=int(str(smtp["port"])),
|
|
smtp_tls=str(smtp.get("tls", "ssl")),
|
|
username=account.email,
|
|
password=password,
|
|
public_only=True, # a server the user named: never one inside our network
|
|
)
|
|
return ImapSmtpProvider(config)
|