lukasandClaude Opus 5
8fce86559e
Three strands that only make sense together, so they land together. Registration gate (migration 0016). POST /auth/register was open to anyone who could reach the port. Now the first account on an empty instance is always allowed, becomes the administrator, and closes registration behind itself; after that it takes an admin reopening it. The decision is made under a row lock on app_settings so two simultaneous first signups cannot both see an empty table and both claim administrator. Existing installs keep their oldest account as admin and start closed. Instance default quota (migration 0017). users.quota_bytes is snapshotted at creation from app_settings.default_quota_bytes, so changing the default affects later accounts only and never resizes a mailbox that exists. The panel is a separate app, not a page in the mail client. admin.html is its own Vite entry (5.8 KB next to the client's 1.7 MB; they share only the vendor chunk), with its own administrator sign-in. One nginx now serves two listeners: :80 is the mail client and 404s both /admin.html and /api/admin/*, :81 is the panel. docker-compose publishes them as WEB_PORT and ADMIN_PORT. The boundary is nginx refusing paths on one listener, not process isolation — CurrentAdmin still guards every admin route — so ADMIN_PORT must be restricted to the LAN, which the runbook now covers for both DSM and QNAP. Also QNAP: deploy/webmail.sh finds Container Station's docker under /share/*/.qpkg/container-station/bin, which is off an SSH session's PATH, before anything shells out to it. docs/nas-install.md gains a QuTS hero runbook (§2.6), splits the DSM firewall section into container-to-container (§8.1) and the egress case that makes account-add time out while autodiscovery appears to work (§8.2), and scopes both to Synology. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SqJYt7jD7oUEkoY68sBZo
56 lines
1.8 KiB
Python
56 lines
1.8 KiB
Python
"""bootstrap administrator + registration gate
|
|
|
|
The first account created on a fresh install becomes the administrator and
|
|
registration closes behind it, so an exposed port cannot be claimed by a
|
|
stranger. Existing installs keep their oldest account as administrator and start
|
|
closed; an admin reopens registration from the admin panel.
|
|
|
|
Revision ID: 0016
|
|
Revises: 0015
|
|
Create Date: 2026-09-15
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import Sequence
|
|
|
|
from alembic import op
|
|
|
|
revision: str = "0016"
|
|
down_revision: str | None = "0015"
|
|
branch_labels: str | Sequence[str] | None = None
|
|
depends_on: str | Sequence[str] | None = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.execute("ALTER TABLE users ADD COLUMN is_admin boolean NOT NULL DEFAULT false")
|
|
op.execute(
|
|
"""
|
|
CREATE TABLE app_settings (
|
|
id integer PRIMARY KEY DEFAULT 1,
|
|
registration_open boolean NOT NULL DEFAULT false,
|
|
updated_at timestamptz NOT NULL DEFAULT now(),
|
|
CONSTRAINT ck_app_settings_singleton CHECK (id = 1)
|
|
)
|
|
"""
|
|
)
|
|
# Existing deployment: the oldest account is the one that set the instance up,
|
|
# so it becomes the administrator. Ties on created_at break by id.
|
|
op.execute(
|
|
"""
|
|
UPDATE users SET is_admin = true
|
|
WHERE id = (SELECT id FROM users ORDER BY created_at, id LIMIT 1)
|
|
"""
|
|
)
|
|
# Fresh install (no users yet) starts open so the first signup can happen;
|
|
# anything else starts closed.
|
|
op.execute(
|
|
"INSERT INTO app_settings (id, registration_open) "
|
|
"VALUES (1, NOT EXISTS (SELECT 1 FROM users))"
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.execute("DROP TABLE IF EXISTS app_settings")
|
|
op.execute("ALTER TABLE users DROP COLUMN IF EXISTS is_admin")
|